imrcpan/freebsd
1
0 Fork 0
mirror of https://github.com/freebsd/freebsd-src.git synced 2026-10-28 11:25:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

stdio: *memstream: slightly streamline growth function

Browse Source 
Inverting the condition after realloc*() is a minor cleanup, but makes
the success path a little cleaner to ease a future change.

Reviewed by:	des, jhb
Sponsored by:	Klara, Inc.
Differential Revision:	https://reviews.freebsd.org/D57353
This commit is contained in:
Kyle Evans committed 2026-07-31 22:34:37 -05:00
1 parent cecb0f45cb
commit 28327c58ee
2 files changed
+15 -18
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

lib/libc/stdio/open_memstream.c
+8 -9
View File
@@ -62,17 +62,16 @@ memstream_grow(struct memstream *ms, fpos_t newoff)
newsize = newoff;
if (newsize > ms->len) {
buf = realloc(*ms->bufp, newsize + 1);
if (buf != NULL) {
if (buf == NULL)
return (0);
#ifdef DEBUG
fprintf(stderr, "MS: %p growing from %zd to %zd\n",
ms, ms->len, newsize);
fprintf(stderr, "MS: %p growing from %zd to %zd\n",
ms, ms->len, newsize);
#endif
memset(buf + ms->len + 1, 0, newsize - ms->len);
*ms->bufp = buf;
ms->len = newsize;
return (1);
}
return (0);
memset(buf + ms->len + 1, 0, newsize - ms->len);
*ms->bufp = buf;
ms->len = newsize;
}
return (1);
}
lib/libc/stdio/open_wmemstream.c
+7 -9
View File
@@ -63,17 +63,15 @@ wmemstream_grow(struct wmemstream *ms, fpos_t newoff)
newsize = newoff;
if (newsize > ms->len) {
buf = reallocarray(*ms->bufp, newsize + 1, sizeof(wchar_t));
if (buf != NULL) {
if (buf == NULL)
return (0);
#ifdef DEBUG
fprintf(stderr, "WMS: %p growing from %zd to %zd\n",
ms, ms->len, newsize);
fprintf(stderr, "WMS: %p growing from %zd to %zd\n",
ms, ms->len, newsize);
#endif
wmemset(buf + ms->len + 1, 0, newsize - ms->len);
*ms->bufp = buf;
ms->len = newsize;
return (1);
}
return (0);
wmemset(buf + ms->len + 1, 0, newsize - ms->len);
*ms->bufp = buf;
ms->len = newsize;
}
return (1);
}