imrcpan/freebsd
1
0 Fork 0
mirror of https://github.com/freebsd/freebsd-src.git synced 2026-10-28 11:25:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

enic: Report device enable failures to iflib

Browse Source 
Do not publish a running interface after vnic_dev_enable_wait() fails.
Run the existing stop cleanup for the queues configured before the enable
request, then report initialization failure to iflib.

Mark those queues as needing cleanup before submitting the enable request
so the stopped-state shortcut cannot skip the unwind.

MFC after:	2 weeks
Sponsored by:	BBOX.io
This commit is contained in:
Kevin Bowling committed 2026-09-16 22:16:42 -07:00
1 parent be36ceea1b
commit 24f8c4e852
1 file changed
+11 -4
Download Patch File Download Diff File Expand all files Collapse all files
sys/dev/enic/if_enic.c
+11 -4
View File
@@ -984,6 +984,7 @@ enic_init(if_ctx_t ctx)
struct enic *enic;
if_softc_ctx_t scctx;
unsigned int index;
int error;
softc = iflib_get_softc(ctx);
scctx = softc->scctx;
@@ -1005,11 +1006,17 @@ enic_init(if_ctx_t ctx)
bcopy(if_getlladdr(softc->ifp), softc->lladdr, ETHER_ADDR_LEN);
enic_set_lladdr(softc);
ENIC_LOCK(softc);
vnic_dev_enable_wait(enic->vdev);
ENIC_UNLOCK(softc);
/* Queue setup above needs normal stop cleanup even if enable fails. */
softc->stopped = 0;
ENIC_LOCK(softc);
error = vnic_dev_enable_wait(enic->vdev);
ENIC_UNLOCK(softc);
if (error != 0) {
device_printf(softc->dev, "Device enable failed: %d\n", error);
enic_stop(ctx);
iflib_init_failed(ctx);
return;
}
enic_link_status(softc);
}