libzfs: report invalid permission name in zfs allow

zfs allow with a typo (e.g. "snapshop") produced the misleading
error "operation not applicable to datasets of this type".  Report
"invalid permission" instead.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by: Christos Longros <[email protected]>
Closes #18401
Closes #11903

lib/libzfs/libzfs_dataset.c

@@ -5138,7 +5138,7 @@ zfs_set_fsacl(zfs_handle_t *zhp, boolean_t un, nvlist_t *nvl)
 			err = zfs_error(hdl, EZFS_BADVERSION, errbuf);
 			break;
 		case EINVAL:
-			err = zfs_error(hdl, EZFS_BADTYPE, errbuf);
+			err = zfs_error(hdl, EZFS_BADPERM, errbuf);
 			break;
 		case ENOENT:
 			err = zfs_error(hdl, EZFS_NOENT, errbuf);