net: qrtr: Fix passing invalid reference to qrtr_local_enqueue()

Once the traversal of the list is completed with list_for_each_entry(),
the iterator (node) will point to an invalid object. So passing this to
qrtr_local_enqueue() which is outside of the iterator block is erroneous
eventhough the object is not used.

So fix this by passing NULL to qrtr_local_enqueue().

Fixes: bdabad3e36 ("net: Add Qualcomm IPC router")
Reported-by: kbuild test robot <[email protected]>
Reported-by: Julia Lawall <[email protected]>
Signed-off-by: Manivannan Sadhasivam <[email protected]>
Reviewed-by: Bjorn Andersson <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
This commit is contained in:
Manivannan Sadhasivam authored and David S. Miller committed 2020-05-21 17:04:53 -07:00
1 parent 7c87e32d2e
commit d28ea1fbbf
1 file changed
+1 -1
+1 -1
View File
@@ -854,7 +854,7 @@ static int qrtr_bcast_enqueue(struct qrtr_node *node, struct sk_buff *skb,
}
mutex_unlock(&qrtr_node_lock);
qrtr_local_enqueue(node, skb, type, from, to);
qrtr_local_enqueue(NULL, skb, type, from, to);
return 0;
}