media: videobuf2: Fix device reference leak in vb2_dc_alloc error path

In vb2_dc_alloc(), get_device() is called to increment the device
reference count. However, if subsequent DMA allocation fails
(vb2_dc_alloc_coherent or vb2_dc_alloc_non_coherent returns error),
the function returns without calling put_device(), causing a device
reference leak.

Add put_device() call in the error path before kfree() to properly
release the device reference acquired earlier.

Fixes: de27891f67 ("media: videobuf2: handle non-contiguous DMA allocations")
Cc: [email protected]
Signed-off-by: Haotian Zhang <[email protected]>
Reviewed-by: Marek Szyprowski <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
This commit is contained in:
Haotian Zhang authored and Hans Verkuil committed 2025-11-03 15:58:42 +01:00
1 parent ba92a96b1e
commit 94de23a9aa
1 file changed
+1
@@ -258,6 +258,7 @@ static void *vb2_dc_alloc(struct vb2_buffer *vb,
if (ret) {
dev_err(dev, "dma alloc of size %lu failed\n", size);
put_device(buf->dev);
kfree(buf);
return ERR_PTR(-ENOMEM);
}