mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git
synced 2026-10-28 12:53:14 +01:00
greybus: manifest: validate string descriptor header
identify_descriptor() computes a string descriptor size from desc->string.length. Require the descriptor to contain the fixed string descriptor header before reading the variable string length. The existing descriptor-size check then reports the short descriptor. Signed-off-by: Pengpeng Hou <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit is contained in:
1 parent
7d3a708af7
commit
18b6510f64
1 file changed
+2
@@ -122,6 +122,8 @@ static int identify_descriptor(struct gb_interface *intf,
|
||||
switch (desc_header->type) {
|
||||
case GREYBUS_TYPE_STRING:
|
||||
expected_size += sizeof(struct greybus_descriptor_string);
|
||||
if (desc_size < expected_size)
|
||||
break;
|
||||
expected_size += desc->string.length;
|
||||
|
||||
/* String descriptors are padded to 4 byte boundaries */
|
||||
|
||||
Reference in new issue
Block a user