Files
freebsd/libexec/rtld-elf/xmalloc.c
T
Konstantin Belousov 559f45638d rtld: add spinlock around the crt malloc calls
Right now, the rtld malloc is called under the write-locked rtld bind
lock. A future change adds places where only read-locked rtld bind lock
is held, and then the spinlock protects the malloc structures from the
parallel updates.

Reviewed by:	kevans
Tested by:	Marek Zarychta <[email protected]>
Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D57908
2026-06-29 23:33:12 +03:00

163 lines
3.4 KiB
C

/*-
* SPDX-License-Identifier: BSD-2-Clause
*
* Copyright 1996-1998 John D. Polstra.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include <sys/param.h>
#include <machine/cpu.h>
#include <machine/cpufunc.h>
#include <stddef.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#include "rtld.h"
#include "rtld_printf.h"
#include "rtld_malloc.h"
#include "rtld_libc.h"
static int rtld_malloc_spinlock;
/*
* Almost always the rtld malloc is called under the write-locked rtld
* bind lock. Due to this, xlock() would need a single CAS to take
* the spinlock. But some places only own read-locked rtld bind lock,
* and then the spinlock protects the malloc structures from the
* parallel updates.
*/
static void
xlock(void)
{
while (atomic_cmpset_acq_int(&rtld_malloc_spinlock, 0, 1) == 0)
cpu_spinwait();
}
static void
xunlock(void)
{
atomic_store_rel_int(&rtld_malloc_spinlock, 0);
}
void *
xcalloc(size_t number, size_t size)
{
void *p;
xlock();
p = __crt_calloc(number, size);
xunlock();
if (p == NULL) {
rtld_fdputstr(STDERR_FILENO, "Out of memory\n");
_exit(1);
}
return (p);
}
void *
xmalloc(size_t size)
{
void *p;
xlock();
p = __crt_malloc(size);
xunlock();
if (p == NULL) {
rtld_fdputstr(STDERR_FILENO, "Out of memory\n");
_exit(1);
}
return (p);
}
char *
xstrdup(const char *str)
{
char *copy;
size_t len;
len = strlen(str) + 1;
copy = xmalloc(len);
memcpy(copy, str, len);
return (copy);
}
void *
xmalloc_aligned(size_t size, size_t align, size_t offset)
{
void *res;
offset &= align - 1;
if (align < sizeof(void *))
align = sizeof(void *);
xlock();
res = __crt_aligned_alloc_offset(align, size, offset);
xunlock();
if (res == NULL) {
rtld_fdputstr(STDERR_FILENO, "Out of memory\n");
_exit(1);
}
return (res);
}
void *
malloc(size_t size)
{
void *p;
xlock();
p = __crt_malloc(size);
xunlock();
return (p);
}
void *
calloc(size_t num, size_t size)
{
void *p;
xlock();
p = __crt_calloc(num, size);
xunlock();
return (p);
}
void
free(void *cp)
{
xlock();
__crt_free(cp);
xunlock();
}
void *
realloc(void *cp, size_t nbytes)
{
void *p;
xlock();
p = __crt_realloc(cp, nbytes);
xunlock();
return (p);
}