mirror of
https://github.com/freebsd/freebsd-src.git
synced 2026-10-28 11:25:21 +01:00
Full release notes are available at https://www.openssh.com/txt/release-10.4 Selected highlights from the release notes: Potentially-incompatible changes -------------------------------- * sshd(8): configuration dump mode ("sshd -G") now writes directives in mixed case (e.g. "PubkeyAuthentication") whereas previously it emitted only lower-case names. * ssh(1), sshd(8): make the transport protocol stricter by disconnecting if the peer sends non-KEX messages during a post- authentication key re-exchange. Previously a malicious peer could continue sending non-key exchange messages without penalty. These would be buffered, causing memory to be wasted up until the connection terminated or the server/client hit a memory limit. Implementations that do not restrict messages sent during key exchange as per RFC4253 section 7.1 may be disconnected. Reported by Marko Jevtic. Changes since OpenSSH 10.3 ========================== This release contains a number of security fixes as well as general bugfixes and a couple of new features. Security ======== * sftp(1): when downloading files on the command-line using "sftp host:/path .", a malicious server could cause the file to be downloaded to an unexpected location. This issue was identified by the Swival Security Scanner. * scp(1): when copying files between two remote destinations, do not allow a malicious server to write files to the parent directory of the intended target directory. This issue was identified by the Swival Security Scanner. * sshd(8): DisableForwarding=yes didn't override PermitTunnel=yes as it was documented to do. Note that PermitTunnel is not enabled by default. Reported independently by Huzaifa Sidhpurwala of Redhat and Marko Jevtic. * sshd(8): avoid a potential pre-authentication denial of service when GSSAPIAuthentication was enabled (this feature is off by default). This was not mitigated by MaxAuthTries, but would be penalised by PerSourcePenalties. This was reported by Manfred Kaiser of the milCERT AT (Austrian Ministry of Defence). * sshd(8): fix a number of cases where the minimum authentication delay was not being enforced. Reported by the Orange Cyberdefense Vulnerability Team. * ssh(1): fix a possible client-side use-after-free if the server changes its host key during a key reexchange. This was reported by Zhenpeng (Leo) Lin of Depthfirst. New features ------------ * All: add experimental support for a composite post-quantum signature scheme that combines ML-DSA 44 and Ed25519 as specified in draft-miller-sshm-mldsa44-ed25519-composite-sigs. This scheme is not enabled by default. To use it, you'll need to add it to HostKeyAlgorithms, PubkeyAcceptedAlgorithms, etc. Keys may be generated using "ssh-keygen -t mldsa44-ed25519". Bugfixes -------- * sshd(8): avoid sending observably different messages for valid vs invalid users in GSSAPIAuthentication (disabled by default). * ssh(1), sshd(8): fix several bugs that incorrectly classified bulk traffic as interactive. bz3972, bz3958 * ssh-keygen(1), ssh-add(1): skip unsupported key types when downloading resident keys from a FIDO token. Previously, downloads would abort when one was encountered. GHPR657 Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58083
369 lines
9.5 KiB
C
369 lines
9.5 KiB
C
/* $OpenBSD: auth2-chall.c,v 1.61 2026/07/06 07:44:48 djm Exp $ */
|
|
/*
|
|
* Copyright (c) 2001 Markus Friedl. All rights reserved.
|
|
* Copyright (c) 2001 Per Allansson. All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
|
|
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
|
|
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
|
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
|
|
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "includes.h"
|
|
|
|
#include <sys/types.h>
|
|
|
|
#include <stdlib.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <stdarg.h>
|
|
|
|
#include "xmalloc.h"
|
|
#include "ssh2.h"
|
|
#include "sshkey.h"
|
|
#include "hostfile.h"
|
|
#include "auth.h"
|
|
#include "sshbuf.h"
|
|
#include "packet.h"
|
|
#include "dispatch.h"
|
|
#include "ssherr.h"
|
|
#include "log.h"
|
|
#include "misc.h"
|
|
#include "servconf.h"
|
|
|
|
/* import */
|
|
extern ServerOptions options;
|
|
|
|
static int auth2_challenge_start(struct ssh *);
|
|
static int send_userauth_info_request(struct ssh *);
|
|
static int input_userauth_info_response(int, uint32_t, struct ssh *);
|
|
|
|
#ifdef BSD_AUTH
|
|
extern KbdintDevice mm_bsdauth_device;
|
|
#else
|
|
#ifdef USE_PAM
|
|
extern KbdintDevice mm_sshpam_device;
|
|
#endif
|
|
#endif
|
|
|
|
KbdintDevice *devices[] = {
|
|
#ifdef BSD_AUTH
|
|
&mm_bsdauth_device,
|
|
#else
|
|
#ifdef USE_PAM
|
|
&mm_sshpam_device,
|
|
#endif
|
|
#endif
|
|
NULL
|
|
};
|
|
|
|
typedef struct KbdintAuthctxt KbdintAuthctxt;
|
|
struct KbdintAuthctxt
|
|
{
|
|
char *devices;
|
|
void *ctxt;
|
|
KbdintDevice *device;
|
|
u_int nreq;
|
|
u_int devices_done;
|
|
};
|
|
|
|
#ifdef USE_PAM
|
|
void
|
|
remove_kbdint_device(const char *devname)
|
|
{
|
|
int i, j;
|
|
|
|
for (i = 0; devices[i] != NULL; i++)
|
|
if (strcmp(devices[i]->name, devname) == 0) {
|
|
for (j = i; devices[j] != NULL; j++)
|
|
devices[j] = devices[j+1];
|
|
i--;
|
|
}
|
|
}
|
|
#endif
|
|
|
|
static KbdintAuthctxt *
|
|
kbdint_alloc(const char *devs)
|
|
{
|
|
KbdintAuthctxt *kbdintctxt;
|
|
struct sshbuf *b;
|
|
int i, r;
|
|
|
|
#ifdef USE_PAM
|
|
if (!options.use_pam)
|
|
remove_kbdint_device("pam");
|
|
#endif
|
|
|
|
kbdintctxt = xcalloc(1, sizeof(KbdintAuthctxt));
|
|
if (strcmp(devs, "") == 0) {
|
|
if ((b = sshbuf_new()) == NULL)
|
|
fatal_f("sshbuf_new failed");
|
|
for (i = 0; devices[i]; i++) {
|
|
if ((r = sshbuf_putf(b, "%s%s",
|
|
sshbuf_len(b) ? "," : "", devices[i]->name)) != 0)
|
|
fatal_fr(r, "buffer error");
|
|
}
|
|
if ((kbdintctxt->devices = sshbuf_dup_string(b)) == NULL)
|
|
fatal_f("sshbuf_dup_string failed");
|
|
sshbuf_free(b);
|
|
} else {
|
|
kbdintctxt->devices = xstrdup(devs);
|
|
}
|
|
debug("kbdint_alloc: devices '%s'", kbdintctxt->devices);
|
|
kbdintctxt->ctxt = NULL;
|
|
kbdintctxt->device = NULL;
|
|
kbdintctxt->nreq = 0;
|
|
|
|
return kbdintctxt;
|
|
}
|
|
static void
|
|
kbdint_reset_device(KbdintAuthctxt *kbdintctxt)
|
|
{
|
|
if (kbdintctxt->ctxt) {
|
|
kbdintctxt->device->free_ctx(kbdintctxt->ctxt);
|
|
kbdintctxt->ctxt = NULL;
|
|
}
|
|
kbdintctxt->device = NULL;
|
|
}
|
|
static void
|
|
kbdint_free(KbdintAuthctxt *kbdintctxt)
|
|
{
|
|
if (kbdintctxt->device)
|
|
kbdint_reset_device(kbdintctxt);
|
|
free(kbdintctxt->devices);
|
|
freezero(kbdintctxt, sizeof(*kbdintctxt));
|
|
}
|
|
/* get next device */
|
|
static int
|
|
kbdint_next_device(Authctxt *authctxt, KbdintAuthctxt *kbdintctxt)
|
|
{
|
|
size_t len;
|
|
char *t;
|
|
size_t i;
|
|
|
|
if (kbdintctxt->device)
|
|
kbdint_reset_device(kbdintctxt);
|
|
do {
|
|
len = kbdintctxt->devices ?
|
|
strcspn(kbdintctxt->devices, ",") : 0;
|
|
|
|
if (len == 0)
|
|
break;
|
|
for (i = 0; devices[i]; i++) {
|
|
if (i >= sizeof(kbdintctxt->devices_done) * 8 ||
|
|
i >= sizeof(devices) / sizeof(devices[0]))
|
|
fatal_f("internal error: too many devices");
|
|
if ((kbdintctxt->devices_done & (1 << i)) != 0 ||
|
|
!auth2_method_allowed(authctxt,
|
|
"keyboard-interactive", devices[i]->name))
|
|
continue;
|
|
if (strlen(devices[i]->name) == len &&
|
|
memcmp(kbdintctxt->devices, devices[i]->name,
|
|
len) == 0) {
|
|
kbdintctxt->device = devices[i];
|
|
kbdintctxt->devices_done |= 1 << i;
|
|
}
|
|
}
|
|
t = kbdintctxt->devices;
|
|
kbdintctxt->devices = t[len] ? xstrdup(t+len+1) : NULL;
|
|
free(t);
|
|
debug2("kbdint_next_device: devices %s", kbdintctxt->devices ?
|
|
kbdintctxt->devices : "<empty>");
|
|
} while (kbdintctxt->devices && !kbdintctxt->device);
|
|
|
|
return kbdintctxt->device ? 1 : 0;
|
|
}
|
|
|
|
/*
|
|
* try challenge-response, set authctxt->postponed if we have to
|
|
* wait for the response.
|
|
*/
|
|
int
|
|
auth2_challenge(struct ssh *ssh, char *devs)
|
|
{
|
|
Authctxt *authctxt = ssh->authctxt;
|
|
debug("auth2_challenge: user=%s devs=%s",
|
|
authctxt->user ? authctxt->user : "<nouser>",
|
|
devs ? devs : "<no devs>");
|
|
|
|
if (authctxt->user == NULL || !devs)
|
|
return 0;
|
|
if (authctxt->kbdintctxt == NULL)
|
|
authctxt->kbdintctxt = kbdint_alloc(devs);
|
|
return auth2_challenge_start(ssh);
|
|
}
|
|
|
|
/* unregister kbd-int callbacks and context */
|
|
void
|
|
auth2_challenge_stop(struct ssh *ssh)
|
|
{
|
|
Authctxt *authctxt = ssh->authctxt;
|
|
/* unregister callback */
|
|
ssh_dispatch_set(ssh, SSH2_MSG_USERAUTH_INFO_RESPONSE, NULL);
|
|
if (authctxt->kbdintctxt != NULL) {
|
|
kbdint_free(authctxt->kbdintctxt);
|
|
authctxt->kbdintctxt = NULL;
|
|
}
|
|
}
|
|
|
|
/* side effect: sets authctxt->postponed if a reply was sent*/
|
|
static int
|
|
auth2_challenge_start(struct ssh *ssh)
|
|
{
|
|
Authctxt *authctxt = ssh->authctxt;
|
|
KbdintAuthctxt *kbdintctxt = authctxt->kbdintctxt;
|
|
|
|
debug2("auth2_challenge_start: devices %s",
|
|
kbdintctxt->devices ? kbdintctxt->devices : "<empty>");
|
|
|
|
if (kbdint_next_device(authctxt, kbdintctxt) == 0) {
|
|
auth2_challenge_stop(ssh);
|
|
return 0;
|
|
}
|
|
debug("auth2_challenge_start: trying authentication method '%s'",
|
|
kbdintctxt->device->name);
|
|
|
|
if ((kbdintctxt->ctxt = kbdintctxt->device->init_ctx(authctxt)) == NULL) {
|
|
auth2_challenge_stop(ssh);
|
|
return 0;
|
|
}
|
|
if (send_userauth_info_request(ssh) == 0) {
|
|
auth2_challenge_stop(ssh);
|
|
return 0;
|
|
}
|
|
ssh_dispatch_set(ssh, SSH2_MSG_USERAUTH_INFO_RESPONSE,
|
|
&input_userauth_info_response);
|
|
|
|
authctxt->postponed = 1;
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
send_userauth_info_request(struct ssh *ssh)
|
|
{
|
|
Authctxt *authctxt = ssh->authctxt;
|
|
KbdintAuthctxt *kbdintctxt;
|
|
char *name, *instr, **prompts;
|
|
u_int r, i, *echo_on;
|
|
|
|
kbdintctxt = authctxt->kbdintctxt;
|
|
if (kbdintctxt->device->query(kbdintctxt->ctxt,
|
|
&name, &instr, &kbdintctxt->nreq, &prompts, &echo_on))
|
|
return 0;
|
|
|
|
if ((r = sshpkt_start(ssh, SSH2_MSG_USERAUTH_INFO_REQUEST)) != 0 ||
|
|
(r = sshpkt_put_cstring(ssh, name)) != 0 ||
|
|
(r = sshpkt_put_cstring(ssh, instr)) != 0 ||
|
|
(r = sshpkt_put_cstring(ssh, "")) != 0 || /* language not used */
|
|
(r = sshpkt_put_u32(ssh, kbdintctxt->nreq)) != 0)
|
|
fatal_fr(r, "start packet");
|
|
for (i = 0; i < kbdintctxt->nreq; i++) {
|
|
if ((r = sshpkt_put_cstring(ssh, prompts[i])) != 0 ||
|
|
(r = sshpkt_put_u8(ssh, echo_on[i])) != 0)
|
|
fatal_fr(r, "assemble packet");
|
|
}
|
|
if ((r = sshpkt_send(ssh)) != 0 ||
|
|
(r = ssh_packet_write_wait(ssh)) != 0)
|
|
fatal_fr(r, "send packet");
|
|
|
|
for (i = 0; i < kbdintctxt->nreq; i++)
|
|
free(prompts[i]);
|
|
free(prompts);
|
|
free(echo_on);
|
|
free(name);
|
|
free(instr);
|
|
return 1;
|
|
}
|
|
|
|
static int
|
|
input_userauth_info_response(int type, uint32_t seq, struct ssh *ssh)
|
|
{
|
|
Authctxt *authctxt = ssh->authctxt;
|
|
KbdintAuthctxt *kbdintctxt;
|
|
int authenticated = 0, res;
|
|
int r;
|
|
u_int i, nresp;
|
|
const char *devicename = NULL;
|
|
char **response = NULL;
|
|
double tstart = monotime_double();
|
|
|
|
if (authctxt == NULL)
|
|
fatal_f("no authctxt");
|
|
kbdintctxt = authctxt->kbdintctxt;
|
|
if (kbdintctxt == NULL || kbdintctxt->ctxt == NULL)
|
|
fatal_f("no kbdintctxt");
|
|
if (kbdintctxt->device == NULL)
|
|
fatal_f("no device");
|
|
|
|
authctxt->postponed = 0; /* reset */
|
|
if ((r = sshpkt_get_u32(ssh, &nresp)) != 0)
|
|
fatal_fr(r, "parse packet");
|
|
if (nresp != kbdintctxt->nreq)
|
|
fatal_f("wrong number of replies");
|
|
if (nresp > 100)
|
|
fatal_f("too many replies");
|
|
if (nresp > 0) {
|
|
response = xcalloc(nresp, sizeof(char *));
|
|
for (i = 0; i < nresp; i++) {
|
|
if ((r = sshpkt_get_cstring(ssh, &response[i], NULL)) != 0)
|
|
fatal_fr(r, "parse response");
|
|
}
|
|
}
|
|
if ((r = sshpkt_get_end(ssh)) != 0)
|
|
fatal_fr(r, "parse packet");
|
|
|
|
res = kbdintctxt->device->respond(kbdintctxt->ctxt, nresp, response);
|
|
|
|
for (i = 0; i < nresp; i++) {
|
|
explicit_bzero(response[i], strlen(response[i]));
|
|
free(response[i]);
|
|
}
|
|
free(response);
|
|
|
|
switch (res) {
|
|
case 0:
|
|
/* Success! */
|
|
authenticated = authctxt->valid ? 1 : 0;
|
|
break;
|
|
case 1:
|
|
/* Authentication needs further interaction */
|
|
if (send_userauth_info_request(ssh) == 1)
|
|
authctxt->postponed = 1;
|
|
break;
|
|
default:
|
|
/* Failure! */
|
|
break;
|
|
}
|
|
devicename = kbdintctxt->device->name;
|
|
if (!authctxt->postponed) {
|
|
if (authenticated) {
|
|
auth2_challenge_stop(ssh);
|
|
} else {
|
|
/* start next device */
|
|
/* may set authctxt->postponed */
|
|
auth2_challenge_start(ssh);
|
|
}
|
|
}
|
|
|
|
if (!authenticated)
|
|
auth_failure_delay(authctxt, tstart);
|
|
userauth_finish(ssh, authenticated, "keyboard-interactive",
|
|
devicename);
|
|
return 0;
|
|
}
|