imrcpan/freebsd
1
0 Fork 0
mirror of https://github.com/freebsd/freebsd-src.git synced 2026-10-28 11:25:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix an uninitialized data access (#16511)

Browse Source 
zfs_acl_node_alloc allocates an uninitialized data buffer, but upstack
zfs_acl_chmod only partially initializes it.  KMSAN reported that this
memory remained uninitialized at the point when it was read by
lzjb_compress, which suggests a possible kernel memory disclosure bug.

The full KMSAN warning may be found in the PR.
https://github.com/openzfs/zfs/pull/16511

Signed-off-by:	Alan Somers <[email protected]>
Sponsored by:	Axcient
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
This commit is contained in:
Alan Somers authored and GitHub committed 2024-09-10 09:08:45 -07:00
1 parent 63253dbf4f
commit 308f7c2f14
2 files changed
+2 -2
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

module/os/freebsd/zfs/zfs_acl.c
+1 -1
View File
@@ -473,7 +473,7 @@ zfs_acl_node_alloc(size_t bytes)
aclnode = kmem_zalloc(sizeof (zfs_acl_node_t), KM_SLEEP);
if (bytes) {
aclnode->z_acldata = kmem_alloc(bytes, KM_SLEEP);
aclnode->z_acldata = kmem_zalloc(bytes, KM_SLEEP);
aclnode->z_allocdata = aclnode->z_acldata;
aclnode->z_allocsize = bytes;
aclnode->z_size = bytes;
module/os/linux/zfs/zfs_acl.c
+1 -1
View File
@@ -471,7 +471,7 @@ zfs_acl_node_alloc(size_t bytes)
aclnode = kmem_zalloc(sizeof (zfs_acl_node_t), KM_SLEEP);
if (bytes) {
aclnode->z_acldata = kmem_alloc(bytes, KM_SLEEP);
aclnode->z_acldata = kmem_zalloc(bytes, KM_SLEEP);
aclnode->z_allocdata = aclnode->z_acldata;
aclnode->z_allocsize = bytes;
aclnode->z_size = bytes;