mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git
synced 2026-10-28 12:53:14 +01:00
A bunch of older cross compilers notably RISCV64 and S390 fail to eliminate
the dead code when CONFIG_AUDITSYSCALL=n. The code in question is:
if (unlikely(audit_context())
syscall_enter_audit(regs);
and in case of CONFIG_AUDITSYSCALL=n:
static inline struct audit_context *audit_context(void)
{
return NULL;
}
which should make the compiler eliminate the syscall_enter_audit()
call. But a RISV64 GCC12 cross compiler translates that into:
if (unlikely(audit_context()))
1c34: 00000097 auipc ra,0x0
1c38: 000080e7 jalr ra # 1c34 <.L785>
1c3c: c511 beqz a0,1c48 <.L787>
syscall_enter_audit(regs);
1c3e: 8526 mv a0,s1
1c40: 00000097 auipc ra,0x0
1c44: 000080e7 jalr ra # 1c40 <.L785+0xc>
and then claims in the failing link:
include/asm-generic/preempt.h:54:(.noinstr.text+0x1a20):
undefined reference to 'syscall_enter_audit'
which is obviously hallucination.
Add an explicit IS_ENABLED(CONFIG_AUDITSYSCALL) check into the condition to
cure this compiler madness.
Fixes: 6f25517010 ("entry: Rework syscall_audit_enter()")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Cc: [email protected]
Link: https://patch.msgid.link/87tso45bqq.ffs@fw13
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
349 lines
11 KiB
C
349 lines
11 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __LINUX_ENTRYCOMMON_H
|
|
#define __LINUX_ENTRYCOMMON_H
|
|
|
|
#include <linux/audit.h>
|
|
#include <linux/irq-entry-common.h>
|
|
#include <linux/livepatch.h>
|
|
#include <linux/ptrace.h>
|
|
#include <linux/randomize_kstack.h>
|
|
#include <linux/resume_user_mode.h>
|
|
#include <linux/seccomp.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/syscall_user_dispatch.h>
|
|
|
|
#include <asm/entry-common.h>
|
|
#include <asm/syscall.h>
|
|
|
|
#ifndef _TIF_UPROBE
|
|
# define _TIF_UPROBE (0)
|
|
#endif
|
|
|
|
/*
|
|
* SYSCALL_WORK flags handled in syscall_enter_from_user_mode_work()
|
|
*/
|
|
#define SYSCALL_WORK_ENTER (SYSCALL_WORK_SECCOMP | \
|
|
SYSCALL_WORK_SYSCALL_TRACEPOINT | \
|
|
SYSCALL_WORK_SYSCALL_TRACE | \
|
|
SYSCALL_WORK_SYSCALL_EMU | \
|
|
SYSCALL_WORK_SYSCALL_AUDIT | \
|
|
SYSCALL_WORK_SYSCALL_USER_DISPATCH | \
|
|
SYSCALL_WORK_SYSCALL_RSEQ_SLICE)
|
|
/*
|
|
* SYSCALL_WORK flags handled in syscall_exit_to_user_mode()
|
|
*/
|
|
#define SYSCALL_WORK_EXIT (SYSCALL_WORK_SYSCALL_TRACEPOINT | \
|
|
SYSCALL_WORK_SYSCALL_TRACE | \
|
|
SYSCALL_WORK_SYSCALL_AUDIT | \
|
|
SYSCALL_WORK_SYSCALL_USER_DISPATCH | \
|
|
SYSCALL_WORK_SYSCALL_EXIT_TRAP)
|
|
|
|
/**
|
|
* arch_ptrace_report_syscall_permit_entry - Architecture specific wrapper for
|
|
* ptrace_report_syscall_permit_entry()
|
|
* @regs: Pointer to the register state at syscall entry
|
|
*
|
|
* Invoked from syscall_trace_enter() to wrap ptrace_report_syscall_permit_entry().
|
|
*
|
|
* This allows architecture specific ptrace_report_syscall_permit_entry()
|
|
* implementations. If not defined by the architecture this falls back to
|
|
* to ptrace_report_syscall_permit_entry().
|
|
*/
|
|
static __always_inline bool arch_ptrace_report_syscall_permit_entry(struct pt_regs *regs);
|
|
|
|
#ifndef arch_ptrace_report_syscall_permit_entry
|
|
static __always_inline bool arch_ptrace_report_syscall_permit_entry(struct pt_regs *regs)
|
|
{
|
|
return ptrace_report_syscall_permit_entry(regs);
|
|
}
|
|
#endif
|
|
|
|
void trace_syscall_enter(struct pt_regs *regs);
|
|
void trace_syscall_exit(struct pt_regs *regs, long ret);
|
|
void syscall_enter_audit(struct pt_regs *regs);
|
|
|
|
static __always_inline long syscall_trace_enter(struct pt_regs *regs, unsigned long work,
|
|
long syscall)
|
|
{
|
|
/*
|
|
* Handle Syscall User Dispatch. This must comes first, since
|
|
* the ABI here can be something that doesn't make sense for
|
|
* other syscall_work features.
|
|
*/
|
|
if (work & SYSCALL_WORK_SYSCALL_USER_DISPATCH) {
|
|
if (syscall_user_dispatch(regs))
|
|
return false;
|
|
}
|
|
|
|
/*
|
|
* User space got a time slice extension granted and relinquishes
|
|
* the CPU. The work stops the slice timer to avoid an extra round
|
|
* through hrtimer_interrupt().
|
|
*/
|
|
if (work & SYSCALL_WORK_SYSCALL_RSEQ_SLICE)
|
|
rseq_syscall_enter_work(syscall);
|
|
|
|
/* Handle ptrace */
|
|
if (work & (SYSCALL_WORK_SYSCALL_TRACE | SYSCALL_WORK_SYSCALL_EMU)) {
|
|
if (!arch_ptrace_report_syscall_permit_entry(regs) ||
|
|
(work & SYSCALL_WORK_SYSCALL_EMU))
|
|
return false;
|
|
|
|
/* ptrace might have changed work flags */
|
|
work = READ_ONCE(current_thread_info()->syscall_work);
|
|
}
|
|
|
|
/* Do seccomp after ptrace, to catch any tracer changes. */
|
|
if (work & SYSCALL_WORK_SECCOMP) {
|
|
if (!__seccomp_permit_syscall())
|
|
return false;
|
|
}
|
|
|
|
if (unlikely(work & SYSCALL_WORK_SYSCALL_TRACEPOINT))
|
|
trace_syscall_enter(regs);
|
|
|
|
/*
|
|
* The config check works around broken compilers which fail to
|
|
* eliminate the dead code in case of CONFIG_AUDITSYSCALL=n as they
|
|
* insist on creating a always false runtime condition based on
|
|
* audit_context() which returns NULL in that case. The explicit
|
|
* IS_ENABLED() check makes that madness go away.
|
|
*/
|
|
if (IS_ENABLED(CONFIG_AUDITSYSCALL) && unlikely(audit_context()))
|
|
syscall_enter_audit(regs);
|
|
|
|
return true;
|
|
}
|
|
|
|
/**
|
|
* syscall_enter_from_user_mode_work - Check and handle work before invoking
|
|
* a syscall
|
|
* @regs: Pointer to currents pt_regs
|
|
* @syscall: The syscall number
|
|
*
|
|
* Invoked from architecture specific syscall entry code with interrupts enabled
|
|
* after invoking enter_from_user_mode(), enabling interrupts and extra
|
|
* architecture specific work with the syscall return value preset to -ENOSYS.
|
|
*
|
|
* Returns: True if the syscall should be invoked, False otherwise.
|
|
*
|
|
* If the return value is false, the caller must skip the syscall and leave the
|
|
* syscall return value unmodified as it might have been set by one of the entry
|
|
* work functions.
|
|
*
|
|
* It handles the following work items:
|
|
*
|
|
* 1) syscall_work flag dependent invocations of
|
|
* ptrace_report_syscall_permit_entry(), __seccomp_permit_syscall(), trace_sys_enter()
|
|
* 2) Invocation of audit_syscall_entry()
|
|
*/
|
|
static __always_inline bool syscall_enter_from_user_mode_work(struct pt_regs *regs, long *syscall)
|
|
{
|
|
unsigned long work = READ_ONCE(current_thread_info()->syscall_work);
|
|
|
|
if (!(work & SYSCALL_WORK_ENTER))
|
|
return true;
|
|
|
|
if (unlikely(!syscall_trace_enter(regs, work, *syscall)))
|
|
return false;
|
|
|
|
/* Reread the syscall number as it might have been modified */
|
|
*syscall = syscall_get_nr(current, regs);
|
|
|
|
return true;
|
|
}
|
|
|
|
/**
|
|
* enter_from_user_mode_randomize_stack - Establish state and add stack randomization
|
|
* before invoking syscall_enter_from_user_mode_work()
|
|
* @regs: Pointer to currents pt_regs
|
|
*
|
|
* Invoked from architecture specific syscall entry code with interrupts
|
|
* disabled. The calling code has to be non-instrumentable. When the function
|
|
* returns all state is correct, interrupts are still disabled and the
|
|
* subsequent functions can be instrumented.
|
|
*
|
|
* Implemented as a macro so that the stack randomization is effective
|
|
* throughout the function in which it is invoked. An inline would only make it
|
|
* effective in the scope of the inline function.
|
|
*/
|
|
#define enter_from_user_mode_randomize_stack(regs) \
|
|
do { \
|
|
enter_from_user_mode(regs); \
|
|
instrumentation_begin(); \
|
|
add_random_kstack_offset_irqsoff(); \
|
|
instrumentation_end(); \
|
|
} while (0)
|
|
|
|
/**
|
|
* syscall_enter_from_user_mode_randomize_stack - Establish state and check and handle work
|
|
* before invoking a syscall
|
|
* @regs: Pointer to currents pt_regs
|
|
* @syscall: The syscall number
|
|
*
|
|
* Invoked from architecture specific syscall entry code with interrupts
|
|
* disabled. The calling code has to be non-instrumentable. When the
|
|
* function returns all state is correct, interrupts are enabled and the
|
|
* subsequent functions can be instrumented.
|
|
*
|
|
* This is the combination of enter_from_user_mode_randomize_stack() and
|
|
* syscall_enter_from_user_mode_work() to be used when there is no
|
|
* architecture specific work to be done between the two.
|
|
*
|
|
* Returns: The original or a modified syscall number. See
|
|
* syscall_enter_from_user_mode_work() for further explanation.
|
|
*
|
|
* Implemented as a macro to make stack randomization effective in the calling
|
|
* scope.
|
|
*/
|
|
#define syscall_enter_from_user_mode_randomize_stack(regs, syscall) \
|
|
({ \
|
|
enter_from_user_mode_randomize_stack(regs); \
|
|
\
|
|
instrumentation_begin(); \
|
|
local_irq_enable(); \
|
|
long _ret = syscall_enter_from_user_mode_work(regs, syscall); \
|
|
instrumentation_end(); \
|
|
\
|
|
_ret; \
|
|
})
|
|
|
|
/*
|
|
* If SYSCALL_EMU is set, then the only reason to report is when SINGLESTEP is
|
|
* set (i.e. PTRACE_SYSEMU_SINGLESTEP). This syscall instruction has been
|
|
* already reported in syscall_enter_from_user_mode_work().
|
|
*/
|
|
static __always_inline bool report_single_step(unsigned long work)
|
|
{
|
|
if (work & SYSCALL_WORK_SYSCALL_EMU)
|
|
return false;
|
|
|
|
return work & SYSCALL_WORK_SYSCALL_EXIT_TRAP;
|
|
}
|
|
|
|
/**
|
|
* arch_ptrace_report_syscall_exit - Architecture specific ptrace_report_syscall_exit()
|
|
* @regs: Pointer to the register state at syscall exit
|
|
* @step: Indicates a single-step exit rather than a normal syscall exit
|
|
*
|
|
* This allows architecture specific ptrace_report_syscall_exit()
|
|
* implementations. If not defined by the architecture this falls back to
|
|
* to ptrace_report_syscall_exit().
|
|
*/
|
|
static __always_inline void arch_ptrace_report_syscall_exit(struct pt_regs *regs,
|
|
int step);
|
|
|
|
#ifndef arch_ptrace_report_syscall_exit
|
|
static __always_inline void arch_ptrace_report_syscall_exit(struct pt_regs *regs,
|
|
int step)
|
|
{
|
|
ptrace_report_syscall_exit(regs, step);
|
|
}
|
|
#endif
|
|
|
|
/**
|
|
* syscall_exit_work - Handle work before returning to user mode
|
|
* @regs: Pointer to current pt_regs
|
|
* @work: Current thread syscall work
|
|
*
|
|
* Do one-time syscall specific work.
|
|
*/
|
|
static __always_inline void syscall_exit_work(struct pt_regs *regs, unsigned long work)
|
|
{
|
|
bool step;
|
|
|
|
/*
|
|
* If the syscall was rolled back due to syscall user dispatching,
|
|
* then the tracers below are not invoked for the same reason as
|
|
* the entry side was not invoked in syscall_trace_enter(): The ABI
|
|
* of these syscalls is unknown.
|
|
*/
|
|
if (work & SYSCALL_WORK_SYSCALL_USER_DISPATCH) {
|
|
if (syscall_user_dispatch_clear_on_dispatch())
|
|
return;
|
|
}
|
|
|
|
audit_syscall_exit(regs);
|
|
|
|
if (work & SYSCALL_WORK_SYSCALL_TRACEPOINT)
|
|
trace_syscall_exit(regs, syscall_get_return_value(current, regs));
|
|
|
|
step = report_single_step(work);
|
|
if (step || work & SYSCALL_WORK_SYSCALL_TRACE)
|
|
arch_ptrace_report_syscall_exit(regs, step);
|
|
}
|
|
|
|
/**
|
|
* syscall_exit_to_user_mode_work - Handle one time work before returning to user mode
|
|
* @regs: Pointer to currents pt_regs
|
|
*
|
|
* Step 1 of syscall_exit_to_user_mode() with the same calling convention.
|
|
*
|
|
* The caller must invoke steps 2-3 of syscall_exit_to_user_mode() afterwards.
|
|
*/
|
|
static __always_inline void syscall_exit_to_user_mode_work(struct pt_regs *regs)
|
|
{
|
|
unsigned long work = READ_ONCE(current_thread_info()->syscall_work);
|
|
unsigned long nr = syscall_get_nr(current, regs);
|
|
|
|
CT_WARN_ON(ct_state() != CT_STATE_KERNEL);
|
|
|
|
if (IS_ENABLED(CONFIG_PROVE_LOCKING)) {
|
|
if (WARN(irqs_disabled(), "syscall %lu left IRQs disabled", nr))
|
|
local_irq_enable();
|
|
}
|
|
|
|
rseq_debug_syscall_return(regs);
|
|
|
|
/*
|
|
* Do one-time syscall specific work. If these work items are
|
|
* enabled, we want to run them exactly once per syscall exit with
|
|
* interrupts enabled.
|
|
*/
|
|
if (unlikely(work & SYSCALL_WORK_EXIT))
|
|
syscall_exit_work(regs, work);
|
|
}
|
|
|
|
/**
|
|
* syscall_exit_to_user_mode - Handle work before returning to user mode
|
|
* @regs: Pointer to currents pt_regs
|
|
*
|
|
* Invoked with interrupts enabled and fully valid @regs. Returns with all
|
|
* work handled, interrupts disabled such that the caller can immediately
|
|
* switch to user mode. Called from architecture specific syscall and ret
|
|
* from fork code.
|
|
*
|
|
* The call order is:
|
|
* 1) One-time syscall exit work:
|
|
* - rseq syscall exit
|
|
* - audit
|
|
* - syscall tracing
|
|
* - ptrace (single stepping)
|
|
*
|
|
* 2) Preparatory work
|
|
* - Disable interrupts
|
|
* - Exit to user mode loop (common TIF handling). Invokes
|
|
* arch_exit_to_user_mode_work() for architecture specific TIF work
|
|
* - Architecture specific one time work arch_exit_to_user_mode_prepare()
|
|
* - Address limit and lockdep checks
|
|
*
|
|
* 3) Final transition (lockdep, tracing, context tracking, RCU), i.e. the
|
|
* functionality in exit_to_user_mode().
|
|
*
|
|
* This is a combination of syscall_exit_to_user_mode_work() (1), disabling
|
|
* interrupts followed by syscall_exit_to_user_mode_prepare() (2) and
|
|
* exit_to_user_mode() (3). This function is preferred unless there is a
|
|
* compelling architectural reason to invoke the functions separately.
|
|
*/
|
|
static __always_inline void syscall_exit_to_user_mode(struct pt_regs *regs)
|
|
{
|
|
instrumentation_begin();
|
|
syscall_exit_to_user_mode_work(regs);
|
|
local_irq_disable();
|
|
syscall_exit_to_user_mode_prepare(regs);
|
|
instrumentation_end();
|
|
exit_to_user_mode();
|
|
}
|
|
|
|
#endif
|