mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git
synced 2026-10-28 12:53:14 +01:00
Stanley Jhu
ec6b083915
bsg-lib allocates a 96-byte (SCSI_SENSE_BUFFERSIZE) reply buffer per
job, but struct ufs_rpmb_reply is 104 bytes: a 40-byte struct
ufs_bsg_reply followed by a 64-byte EHS. When an Advanced RPMB command
returns an EHS, ufshcd_advanced_rpmb_req_handler() copies it right after
the 40-byte header and writes 8 bytes past the end of the buffer.
Let each BSG transport pass its reply buffer size to bsg_setup_queue()
and have ufs_bsg request sizeof(struct ufs_rpmb_reply), so the full
reply reaches user space. Other transports keep SCSI_SENSE_BUFFERSIZE.
Fixes: 6ff265fc5e ("scsi: ufs: core: bsg: Add advanced RPMB support in ufs_bsg")
Cc: [email protected]
Signed-off-by: Stanley Jhu <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Martin K. Petersen (Oracle) <[email protected]>
76 lines
1.7 KiB
C
76 lines
1.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* BSG helper library
|
|
*
|
|
* Copyright (C) 2008 James Smart, Emulex Corporation
|
|
* Copyright (C) 2011 Red Hat, Inc. All rights reserved.
|
|
* Copyright (C) 2011 Mike Christie
|
|
*/
|
|
#ifndef _BLK_BSG_
|
|
#define _BLK_BSG_
|
|
|
|
#include <linux/blkdev.h>
|
|
|
|
struct bsg_job;
|
|
struct request;
|
|
struct device;
|
|
struct scatterlist;
|
|
struct request_queue;
|
|
|
|
typedef int (bsg_job_fn) (struct bsg_job *);
|
|
typedef enum blk_eh_timer_return (bsg_timeout_fn)(struct request *);
|
|
|
|
struct bsg_buffer {
|
|
unsigned int payload_len;
|
|
int sg_cnt;
|
|
struct scatterlist *sg_list;
|
|
};
|
|
|
|
struct bsg_job {
|
|
struct device *dev;
|
|
|
|
struct kref kref;
|
|
|
|
unsigned int timeout;
|
|
|
|
/* Transport/driver specific request/reply structs */
|
|
void *request;
|
|
void *reply;
|
|
|
|
unsigned int request_len;
|
|
unsigned int reply_len;
|
|
/*
|
|
* On entry : reply_len indicates the buffer size allocated for
|
|
* the reply.
|
|
*
|
|
* Upon completion : the message handler must set reply_len
|
|
* to indicates the size of the reply to be returned to the
|
|
* caller.
|
|
*/
|
|
|
|
/* DMA payloads for the request/response */
|
|
struct bsg_buffer request_payload;
|
|
struct bsg_buffer reply_payload;
|
|
|
|
int result;
|
|
unsigned int reply_payload_rcv_len;
|
|
|
|
/* BIDI support */
|
|
struct request *bidi_rq;
|
|
struct bio *bidi_bio;
|
|
|
|
void *dd_data; /* Used for driver-specific storage */
|
|
};
|
|
|
|
void bsg_job_done(struct bsg_job *job, int result,
|
|
unsigned int reply_payload_rcv_len);
|
|
struct request_queue *bsg_setup_queue(struct device *dev, const char *name,
|
|
struct queue_limits *lim, bsg_job_fn *job_fn,
|
|
bsg_timeout_fn *timeout, int dd_job_size,
|
|
unsigned int reply_len);
|
|
void bsg_remove_queue(struct request_queue *q);
|
|
void bsg_job_put(struct bsg_job *job);
|
|
int __must_check bsg_job_get(struct bsg_job *job);
|
|
|
|
#endif
|