Eric Dumazet 954fba0274 netpoll: fix netpoll_send_udp() bugs ...

Bogdan Hamciuc diagnosed and fixed following bug in netpoll_send_udp() :

"skb->len += len;" instead of "skb_put(skb, len);"

Meaning that _if_ a network driver needs to call skb_realloc_headroom(),
only packet headers would be copied, leaving garbage in the payload.

However the skb_realloc_headroom() must be avoided as much as possible
since it requires memory and netpoll tries hard to work even if memory
is exhausted (using a pool of preallocated skbs)

It appears netpoll_send_udp() reserved 16 bytes for the ethernet header,
which happens to work for typicall drivers but not all.

Right thing is to use LL_RESERVED_SPACE(dev)
(And also add dev->needed_tailroom of tailroom)

This patch combines both fixes.

Many thanks to Bogdan for raising this issue.

Reported-by: Bogdan Hamciuc <[email protected]>
Signed-off-by: Eric Dumazet <[email protected]>
Tested-by: Bogdan Hamciuc <[email protected]>
Cc: Herbert Xu <[email protected]>
Cc: Neil Horman <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Cong Wang <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

2012-06-13 15:57:31 -07:00

..

datagram.c

net: cleanup unsigned to unsigned int

2012-04-15 12:44:40 -04:00

dev_addr_lists.c

net: addr_list: add exclusive dev_uc_add and dev_mc_add

2012-04-15 13:06:04 -04:00

dev.c

net: napi_frags_skb() is static

2012-05-19 02:51:00 -04:00

drop_monitor.c

drop_monitor: dont sleep in atomic context

2012-06-04 11:42:01 -04:00

dst.c

…

ethtool.c

ethtool: Extend the ethtool API to obtain plugin module eeprom data

2012-05-10 02:22:17 +01:00

fib_rules.c

fib_rules: Stop using NLA_PUT*().

2012-04-02 04:33:44 -04:00

filter.c

net/core: fix kernel-doc warnings

2012-06-08 22:20:58 -07:00

flow_dissector.c

net: flow_dissector.c missing include linux/export.h

2012-01-24 16:03:33 -05:00

flow.c

net: Add a flow_cache_flush_deferred function

2011-12-21 16:48:08 -05:00

gen_estimator.c

Remove all #inclusions of asm/system.h

2012-03-28 18:30:03 +01:00

gen_stats.c

gen_stats: Stop using NLA_PUT*().

2012-04-02 04:33:44 -04:00

iovec.c

net: get rid of some pointless casts to sockaddr

2012-03-11 19:11:22 -07:00

link_watch.c

…

Makefile

…

neighbour.c

net: neighbour: fix neigh_dump_info()

2012-06-07 13:02:21 -07:00

net_namespace.c

net: core: Use pr_<level>

2012-05-17 05:00:04 -04:00

net-sysfs.c

net: cleanup unsigned to unsigned int

2012-04-15 12:44:40 -04:00

net-sysfs.h

…

net-traces.c

…

netevent.c

…

netpoll.c

netpoll: fix netpoll_send_udp() bugs

2012-06-13 15:57:31 -07:00

netprio_cgroup.c

Merge branch 'for-3.5' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup

2012-05-22 17:40:19 -07:00

pktgen.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2012-05-20 21:53:04 -04:00

request_sock.c

…

rtnetlink.c

net: Convert net_ratelimit uses to net_<level>_ratelimited

2012-05-15 13:45:03 -04:00

scm.c

Remove all #inclusions of asm/system.h

2012-03-28 18:30:03 +01:00

secure_seq.c

net: fix some sparse errors

2012-01-17 10:31:12 -05:00

skbuff.c

net/core: fix kernel-doc warnings

2012-06-08 22:20:58 -07:00

sock_diag.c

net: sock_diag_handler structs can be const

2012-04-25 20:46:59 -04:00

sock.c

net: sock: validate data_len before allocating skb in sock_alloc_send_pskb()

2012-05-31 18:22:45 -04:00

stream.c

…

sysctl_net_core.c

net: Delete all remaining instances of ctl_path

2012-04-20 21:22:30 -04:00

timestamping.c

…

user_dma.c

…

utils.c

net: Fixed coding style issues relating to braces.

2012-04-12 16:35:48 -04:00