Colin Ian King ca4da5dd1f KEYS: ensure we free the assoc array edit if edit is valid ...

__key_link_end is not freeing the associated array edit structure
and this leads to a 512 byte memory leak each time an identical
existing key is added with add_key().

The reason the add_key() system call returns okay is that
key_create_or_update() calls __key_link_begin() before checking to see
whether it can update a key directly rather than adding/replacing - which
it turns out it can.  Thus __key_link() is not called through
__key_instantiate_and_link() and __key_link_end() must cancel the edit.

CVE-2015-1333

Signed-off-by: Colin Ian King <[email protected]>
Signed-off-by: David Howells <[email protected]>
Signed-off-by: James Morris <[email protected]>

2015-07-28 13:08:23 +10:00

..

encrypted-keys

KEYS: Fix stale key registration at error path

2014-12-06 21:50:36 -05:00

big_key.c

KEYS: Remove key_type::match in favour of overriding default by match_preparse

2014-09-16 17:36:06 +01:00

compat.c

switch keyctl_instantiate_key_common() to iov_iter

2015-04-11 22:27:12 -04:00

gc.c

KEYS: close race between key lookup and freeing

2015-01-05 15:58:01 +00:00

internal.h

switch keyctl_instantiate_key_common() to iov_iter

2015-04-11 22:27:12 -04:00

Kconfig

KEYS: Make /proc/keys unconditional if CONFIG_KEYS=y

2015-01-22 22:34:32 +00:00

key.c

KEYS: remove a bogus NULL check

2014-12-16 18:05:20 +11:00

keyctl.c

switch keyctl_instantiate_key_common() to iov_iter

2015-04-11 22:27:12 -04:00

keyring.c

KEYS: ensure we free the assoc array edit if edit is valid

2015-07-28 13:08:23 +10:00

Makefile

…

permission.c

KEYS: Move the flags representing required permission to linux/key.h

2014-03-14 17:44:49 +00:00

persistent.c

KEYS: Move the flags representing required permission to linux/key.h

2014-03-14 17:44:49 +00:00

proc.c

KEYS: Make /proc/keys unconditional if CONFIG_KEYS=y

2015-01-22 22:34:32 +00:00

process_keys.c

KEYS: Make the key matching functions return bool

2014-09-16 17:36:08 +01:00

request_key_auth.c

KEYS: Simplify KEYRING_SEARCH_{NO,DO}_STATE_CHECK flags

2014-12-01 22:52:50 +00:00

request_key.c

Don't leak a key reference if request_key() tries to use a revoked keyring

2015-02-16 13:45:16 +11:00

sysctl.c

security: Convert use of typedef ctl_table to struct ctl_table

2014-04-15 13:39:58 +10:00

trusted.c

KEYS: Remove key_type::match in favour of overriding default by match_preparse

2014-09-16 17:36:06 +01:00

trusted.h

…

user_defined.c

KEYS: Remove key_type::match in favour of overriding default by match_preparse

2014-09-16 17:36:06 +01:00