Arnd Bergmann 3e1b6469f8 mtd: lpddr: fix excessive stack usage with clang ...

Building lpddr2_nvm with clang can result in a giant stack usage
in one function:

drivers/mtd/lpddr/lpddr2_nvm.c:399:12: error: stack frame size of 1144 bytes in function 'lpddr2_nvm_probe' [-Werror,-Wframe-larger-than=]

The problem is that clang decides to build a copy of the mtd_info
structure on the stack and then do a memcpy() into the actual version. It
shouldn't really do it that way, but it's not strictly a bug either.

As a workaround, use a static const version of the structure to assign
most of the members upfront and then only set the few members that
require runtime knowledge at probe time.

Fixes: 96ba9dd657 ("mtd: lpddr: add driver for LPDDR2-NVM PCM memories")
Signed-off-by: Arnd Bergmann <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Acked-by: Miquel Raynal <[email protected]>
Signed-off-by: Miquel Raynal <[email protected]>
Link: https://lore.kernel.org/linux-mtd/[email protected]

2020-08-27 14:36:07 +02:00

..

Kconfig

…

lpddr2_nvm.c

mtd: lpddr: fix excessive stack usage with clang

2020-08-27 14:36:07 +02:00

lpddr_cmds.c

mtd: lpddr: Move function print_drs_error to lpddr_cmds.c

2020-08-27 14:14:46 +02:00

Makefile

…

qinfo_probe.c

…