mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git
synced 2026-10-30 22:03:17 +01:00
Masahiro Yamada
163ba35ff3
You should use KCFLAGS to pass additional compiler flags from the
command line. Using EXTRA_CFLAGS is wrong.
EXTRA_CFLAGS is supposed to specify flags applied only to the current
Makefile (and now deprecated in favor of ccflags-y).
It is still used in arch/mips/kvm/Makefile (and possibly in external
modules too). Passing EXTRA_CFLAGS from the command line overwrites
it and breaks the build.
I also fixed drivers/gpu/drm/tilcdc/Makefile because commit 816175dd1f
("drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in
EXTRA_CFLAGS") was based on the same misunderstanding.
Signed-off-by: Masahiro Yamada <[email protected]>
Reviewed-by: Alex Shi <[email protected]>
Acked-by: Federico Vaga <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jonathan Corbet <[email protected]>
14 lines
241 B
Makefile
14 lines
241 B
Makefile
# SPDX-License-Identifier: GPL-2.0
|
|
ifeq (, $(findstring -W,$(KCFLAGS)))
|
|
ccflags-y += -Werror
|
|
endif
|
|
|
|
tilcdc-y := \
|
|
tilcdc_plane.o \
|
|
tilcdc_crtc.o \
|
|
tilcdc_panel.o \
|
|
tilcdc_external.o \
|
|
tilcdc_drv.o
|
|
|
|
obj-$(CONFIG_DRM_TILCDC) += tilcdc.o
|