Miklos Szeredi fed474857e fsnotify: don't BUG in fsnotify_destroy_mark() ...

Removing the parent of a watched file results in "kernel BUG at
fs/notify/mark.c:139".

To reproduce

  add "-w /tmp/audit/dir/watched_file" to audit.rules
  rm -rf /tmp/audit/dir

This is caused by fsnotify_destroy_mark() being called without an
extra reference taken by the caller.

Reported by Francesco Cosoleto here:

  https://bugzilla.novell.com/show_bug.cgi?id=689860

Fix by removing the BUG_ON and adding a comment about not accessing mark after
the iput.

Signed-off-by: Miklos Szeredi <[email protected]>
CC: [email protected]
Signed-off-by: Linus Torvalds <[email protected]>

2012-01-14 18:01:42 -08:00

..

dnotify

…

fanotify

vfs: move fsnotify junk to struct mount

2012-01-03 22:57:12 -05:00

inotify

…

fsnotify.c

vfs: move fsnotify junk to struct mount

2012-01-03 22:57:12 -05:00

fsnotify.h

…

group.c

…

inode_mark.c

…

Kconfig

…

Makefile

…

mark.c

fsnotify: don't BUG in fsnotify_destroy_mark()

2012-01-14 18:01:42 -08:00

notification.c

…

vfsmount_mark.c

vfs: move fsnotify junk to struct mount

2012-01-03 22:57:12 -05:00