Jia-Ju Bai 13eac05b05 tty: ipwireless: Replace GFP_ATOMIC with GFP_KERNEL in ipwireless_network_create ...

ipwireless_network_create() is never called in atomic context.

The call chain ending up at ipwireless_network_create() is:
[1] ipwireless_network_create() <- config_ipwireless() <-
	ipwireless_attach()
ipwireless_attach() is only set as ".probe" in struct pcmcia_driver.

Despite never getting called from atomic context,
ipwireless_network_create() calls kzalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <[email protected]>
Reviewed-by: David Sterba <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

2018-04-23 10:57:06 +02:00

..

hardware.c

treewide: setup_timer() -> timer_setup()

2017-11-21 15:57:07 -08:00

hardware.h

…

main.c

…

main.h

…

Makefile

…

network.c

tty: ipwireless: Replace GFP_ATOMIC with GFP_KERNEL in ipwireless_network_create

2018-04-23 10:57:06 +02:00

network.h

…

setup_protocol.h

…

tty.c

…

tty.h

…