mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git
synced 2026-10-28 12:53:14 +01:00
Frank Sorenson
19465a9aeb
The invalidHandle, swapfile, oplock_break_cancelled, offload, and status_file_deleted fields are stored in the same bitfield byte in struct cifsFileInfo, but are updated in different code paths that may run simultaneously, and are protected by different locks. Since bitfield assignments generate byte-level read-modify-write operations, a modification to one flag can overwrite a concurrent modification to another flag. To avoid these races, convert these flags from a bitfield to separate bool fields. Closes: https://lore.kernel.org/r/[email protected] Fixes:3bc303c254("cifs: convert oplock breaks to use slow_work facility (try #4)") Fixes:4e8aea30f7("smb3: enable swap on SMB3 mounts") Fixes:ffceb7640c("smb: client: do not defer close open handles to deleted files") Fixes:173217bd73("smb3: retrying on failed server close") Signed-off-by: Frank Sorenson <[email protected]> Cc: [email protected] Reviewed-by: Namjae Jeon <[email protected]> Signed-off-by: Paulo Alcantara <[email protected]>