mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git
synced 2026-10-30 22:03:17 +01:00
Hans de Goede
e298d8a38b
led_blink_set[_oneshot]()'s delay_on and delay_off function parameters are pass by reference, so that hw-blink implementations can report back the actual achieved delays when the values have been rounded to something the hw supports. This is really only interesting for the sysfs API / the timer trigger. Other triggers don't really care about this and none of the callers of led_trigger_blink[_oneshot]() do anything with the returned delay values. Change the led_trigger_blink[_oneshot]() delay parameters to pass-by-value, there are 2 reasons for this: 1. led_cdev->blink_set() may sleep, while led_trigger_blink() may not. So on hw where led_cdev->blink_set() sleeps the call needs to be deferred to a workqueue, in which case the actual achieved delays are unknown (this is a preparation patch for the deferring). 2. Since the callers don't care about the actual achieved delays, allowing callers to directly pass a value leads to simpler code for most callers. Signed-off-by: Hans de Goede <[email protected]> Reviewed-by: Jacek Anaszewski <[email protected]> Tested-by: Yauhen Kharuzhy <[email protected]> Acked-by: Greg Kroah-Hartman <[email protected]> Acked-by: Sebastian Reichel <[email protected]> Acked-by: Florian Westphal <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Lee Jones <[email protected]>
49 lines
1.1 KiB
C
49 lines
1.1 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* LED Triggers for USB Activity
|
|
*
|
|
* Copyright 2014 Michal Sojka <[email protected]>
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/init.h>
|
|
#include <linux/leds.h>
|
|
#include <linux/usb.h>
|
|
#include "common.h"
|
|
|
|
#define BLINK_DELAY 30
|
|
|
|
DEFINE_LED_TRIGGER(ledtrig_usb_gadget);
|
|
DEFINE_LED_TRIGGER(ledtrig_usb_host);
|
|
|
|
void usb_led_activity(enum usb_led_event ev)
|
|
{
|
|
struct led_trigger *trig = NULL;
|
|
|
|
switch (ev) {
|
|
case USB_LED_EVENT_GADGET:
|
|
trig = ledtrig_usb_gadget;
|
|
break;
|
|
case USB_LED_EVENT_HOST:
|
|
trig = ledtrig_usb_host;
|
|
break;
|
|
}
|
|
/* led_trigger_blink_oneshot() handles trig == NULL gracefully */
|
|
led_trigger_blink_oneshot(trig, BLINK_DELAY, BLINK_DELAY, 0);
|
|
}
|
|
EXPORT_SYMBOL_GPL(usb_led_activity);
|
|
|
|
|
|
void __init ledtrig_usb_init(void)
|
|
{
|
|
led_trigger_register_simple("usb-gadget", &ledtrig_usb_gadget);
|
|
led_trigger_register_simple("usb-host", &ledtrig_usb_host);
|
|
}
|
|
|
|
void __exit ledtrig_usb_exit(void)
|
|
{
|
|
led_trigger_unregister_simple(ledtrig_usb_gadget);
|
|
led_trigger_unregister_simple(ledtrig_usb_host);
|
|
}
|