Fan Wu
9ee8306121
iio: adc: ad_sigma_delta: fix use-after-free on unbind
...
ad_sd_buffer_postenable() allocates sigma_delta->samples_buf with
devm_krealloc() at runtime, so its devres entry sits after all
probe-time entries of the driver. devm resources are released in
reverse allocation order, which means unbind frees samples_buf before
iio_device_unregister() disables the buffers and detaches the trigger
pollfunc. The data ready IRQ is still enabled at that point, so
ad_sd_trigger_handler() can still run and memcpy() incoming samples
into the freed samples_buf.
Fix this by preallocating the buffer in
devm_ad_sd_setup_buffer_and_trigger(), before the triggered buffer and
the IRQ are set up, so it is freed only after iio_device_unregister()
has drained the trigger handler via free_irq(). Size it for the worst
case of all sequencer slots being active; ad_sd_validate_scan_mask()
already caps the number of active channels at num_slots.
This issue was found by an in-house static analysis tool.
Fixes: 8bea9af887 ("iio: adc: ad_sigma_delta: Add sequencer support")
Cc: [email protected]
Co-developed-by: Song Li <[email protected] >
Signed-off-by: Song Li <[email protected] >
Signed-off-by: Fan Wu <[email protected] >
Reviewed-by: Nuno Sá <[email protected] >
Signed-off-by: Jonathan Cameron <[email protected] >
2026-09-30 18:59:56 +01:00
..
2026-07-20 02:43:15 +01:00
2026-05-31 11:01:46 +01:00
2026-07-06 16:59:47 +01:00
2026-09-30 18:59:55 +01:00
2026-04-27 09:58:18 +01:00
2026-08-19 09:45:01 +02:00
2026-06-30 00:15:56 +01:00
2026-07-06 16:59:47 +01:00
2026-06-30 00:15:56 +01:00
2026-07-03 07:38:17 +02:00
2026-04-28 16:36:09 +01:00
2026-07-06 16:59:47 +01:00
2026-05-31 11:01:46 +01:00
2026-06-30 00:15:56 +01:00
2026-07-06 16:59:47 +01:00
2026-09-30 18:59:55 +01:00
2026-07-06 16:59:47 +01:00
2026-07-06 16:59:47 +01:00
2026-06-30 00:15:56 +01:00
2026-09-04 21:37:00 -07:00
2026-05-31 11:01:46 +01:00
2026-07-06 16:59:47 +01:00
2026-07-06 16:59:47 +01:00
2026-06-30 00:15:56 +01:00
2026-07-03 07:38:17 +02:00
2026-06-30 00:15:56 +01:00
2026-07-03 07:38:17 +02:00
2026-06-30 00:15:56 +01:00
2026-05-31 11:01:48 +01:00
2026-07-03 07:38:17 +02:00
2026-06-30 00:15:56 +01:00
2026-06-30 00:15:56 +01:00
2026-07-06 16:59:47 +01:00
2026-06-30 00:15:56 +01:00
2026-06-30 00:15:56 +01:00
2026-06-30 00:15:56 +01:00
2026-06-30 00:15:56 +01:00
2026-06-30 00:15:56 +01:00
2026-06-30 00:15:56 +01:00
2026-06-30 00:15:56 +01:00
2026-06-30 00:15:56 +01:00
2026-09-30 18:59:56 +01:00
2026-09-30 18:59:55 +01:00
2026-08-31 00:52:40 +01:00
2026-08-31 00:52:42 +01:00
2026-07-27 22:13:07 +01:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-09-05 02:44:00 +01:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-05-31 11:01:49 +01:00
2026-07-03 07:38:17 +02:00
2026-05-31 11:01:48 +01:00
2026-07-06 16:59:47 +01:00
2026-07-03 07:38:17 +02:00
2026-05-31 11:01:46 +01:00
2026-07-06 16:59:47 +01:00
2026-07-06 16:59:47 +01:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-05-31 11:01:46 +01:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-08-19 09:45:01 +02:00
2026-07-03 07:38:17 +02:00
2026-07-12 12:37:28 -07:00
2026-05-31 11:01:46 +01:00
2026-08-03 22:32:33 +01:00
2026-05-31 11:01:46 +01:00
2026-05-31 11:01:46 +01:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-08-03 22:32:33 +01:00
2026-07-06 16:59:47 +01:00
2026-07-06 16:59:47 +01:00
2026-07-05 00:57:10 +01:00
2026-08-31 00:52:40 +01:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-06-30 00:15:56 +01:00
2026-06-30 00:15:56 +01:00
2026-07-06 16:59:47 +01:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-07-06 16:59:47 +01:00
2026-07-03 07:38:17 +02:00
2026-06-30 00:15:56 +01:00
2026-07-06 16:59:47 +01:00
2026-05-15 12:05:34 +01:00
2026-07-03 07:38:17 +02:00
2026-07-13 01:32:46 +01:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-07-12 12:37:28 -07:00
2026-08-07 23:51:05 +01:00
2026-09-21 00:58:42 +01:00
2026-07-03 07:38:17 +02:00
2026-08-07 17:18:44 +02:00
2026-07-03 07:38:17 +02:00
2026-05-26 19:22:57 +01:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-08-03 22:32:32 +01:00
2026-07-06 16:59:47 +01:00
2026-08-31 00:52:40 +01:00
2026-07-06 16:59:47 +01:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-07-12 12:37:28 -07:00
2026-09-30 18:59:55 +01:00
2026-06-30 00:15:53 +01:00
2026-09-06 18:35:10 +01:00
2026-07-03 07:38:17 +02:00
2026-03-21 19:13:12 +00:00
2026-07-06 16:59:47 +01:00
2026-07-06 16:59:47 +01:00
2026-07-06 16:59:47 +01:00
2026-07-06 16:59:47 +01:00
2026-07-06 16:59:47 +01:00
2026-07-06 16:59:47 +01:00
2026-06-30 00:15:56 +01:00
2026-08-03 22:32:31 +01:00
2026-08-19 09:45:01 +02:00
2026-06-30 00:15:56 +01:00
2026-07-06 16:59:47 +01:00
2026-07-04 00:07:34 +01:00
2026-07-06 16:59:47 +01:00
2026-05-31 11:01:46 +01:00
2026-06-29 23:24:45 +01:00
2026-06-30 00:15:56 +01:00
2026-08-07 23:49:34 +01:00
2026-05-31 11:01:46 +01:00
2026-06-30 00:15:56 +01:00
2026-07-06 16:59:47 +01:00
2026-06-30 00:15:56 +01:00
2026-07-06 16:59:47 +01:00
2026-07-01 18:38:38 +01:00
2026-07-03 07:38:17 +02:00
2026-07-03 07:38:17 +02:00
2026-07-02 16:43:51 +01:00
2026-07-02 16:43:51 +01:00
2026-07-02 16:43:51 +01:00
2026-07-02 16:43:51 +01:00
2026-07-03 07:38:17 +02:00
2026-05-15 12:05:35 +01:00
2026-07-03 07:38:17 +02:00
2026-08-31 00:52:41 +01:00