When compile testing the UAPI headers with clang, there is an warning turned
error for using a C++ style ('//') comment, which is explicitly forbidden for
UAPI headers.
In file included from <built-in>:1:
./usr/include/linux/virtio_can.h:29:35: error: // comments are not allowed in this language [-Werror,-Wcomment]
29 | #define VIRTIO_CAN_MAX_DLEN 64 // this is like CANFD_MAX_DLEN
| ^
1 error generated.
Switch to a standard C style comment.
Fixes: 2b6b4bb7d96f ("can: virtio: Add virtio CAN driver")
Signed-off-by: Nathan Chancellor <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Message-ID: <20260604-virtio_can-fix-uapi-comment-v1-1-199fa96ec5f0@kernel.org>
Add virtio CAN driver based on Virtio 1.4 specification (see
https://github.com/oasis-tcs/virtio-spec/tree/virtio-1.4). The driver
implements a complete CAN bus interface over Virtio transport,
supporting both CAN Classic and CAN-FD Ids. In term of frames, it
supports classic and CAN FD. RTR frames are only supported with classic
CAN.
Usage:
- "ip link set up can0" - start controller
- "ip link set down can0" - stop controller
- "candump can0" - receive frames
- "cansend can0 123#DEADBEEF" - send frames
Signed-off-by: Harald Mommer <[email protected]>
Co-developed-by: Harald Mommer <[email protected]>
Signed-off-by: Mikhail Golubev-Ciuchea <[email protected]>
Co-developed-by: Marc Kleine-Budde <[email protected]>
Signed-off-by: Marc Kleine-Budde <[email protected]>
Cc: Damir Shaikhutdinov <[email protected]>
Reviewed-by: Francesco Valla <[email protected]>
Tested-by: Francesco Valla <[email protected]>
Signed-off-by: Matias Ezequiel Vara Larsen <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Message-ID: <ahXNb+KzuHYbS24+@fedora>
Nathan Chancellor