mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git
synced 2026-10-31 06:14:39 +01:00
Revert "usb: typec: mux: avoid duplicated mux switches"
This reverts commitb145c3f29d. The deduplication logic appears to cause issues with separate SBU muxes. The mode-switch call on these (like gpio-sbu-mux) never appeared, so no successful mode-switch happened. The more high-end Parade PS883X redrivers are not affected due to being retimer-switch. The revert fixes dp altmode mode-switch for both. Tested on: Lenovo Thinkbook 16 G7 QOY Lenovo Ideapad 5 2in1 14Q8X9 Microsoft Windows Dev Kit 2023 (Blackrock) Lenovo Thinkpad T14s G6 Fixes:b145c3f29d("usb: typec: mux: avoid duplicated mux switches") Cc: stable <[email protected]> Signed-off-by: Jens Glathe <[email protected]> Reviewed-by: Heikki Krogerus <[email protected]> Link: https://patch.msgid.link/20260530-typc-mux-modeset-v1-1-64b0281e2cd6@oldschoolsolutions.biz Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit is contained in:
1 parent
abf76d3239
commit
f576c75f95
1 file changed
+1
-12
+1
-12
@@ -275,9 +275,7 @@ static int mux_fwnode_match(struct device *dev, const void *fwnode)
|
||||
static void *typec_mux_match(const struct fwnode_handle *fwnode,
|
||||
const char *id, void *data)
|
||||
{
|
||||
struct typec_mux_dev **mux_devs = data;
|
||||
struct device *dev;
|
||||
int i;
|
||||
|
||||
/*
|
||||
* Device graph (OF graph) does not give any means to identify the
|
||||
@@ -293,14 +291,6 @@ static void *typec_mux_match(const struct fwnode_handle *fwnode,
|
||||
dev = class_find_device(&typec_mux_class, NULL, fwnode,
|
||||
mux_fwnode_match);
|
||||
|
||||
/* Skip duplicates */
|
||||
for (i = 0; i < TYPEC_MUX_MAX_DEVS; i++)
|
||||
if (to_typec_mux_dev(dev) == mux_devs[i]) {
|
||||
put_device(dev);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
|
||||
return dev ? to_typec_mux_dev(dev) : ERR_PTR(-EPROBE_DEFER);
|
||||
}
|
||||
|
||||
@@ -326,8 +316,7 @@ struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode)
|
||||
return ERR_PTR(-ENOMEM);
|
||||
|
||||
count = fwnode_connection_find_matches(fwnode, "mode-switch",
|
||||
(void **)mux_devs,
|
||||
typec_mux_match,
|
||||
NULL, typec_mux_match,
|
||||
(void **)mux_devs,
|
||||
ARRAY_SIZE(mux_devs));
|
||||
if (count <= 0) {
|
||||
|
||||
Reference in new issue
Block a user