mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git
synced 2026-10-30 05:42:46 +01:00
rv: Fix wrong type cast in enabled_monitors_next()
Argument 'p' of enabled_monitors_next() is not a pointer to struct rv_monitor, it is actually a pointer to the list_head inside struct rv_monitor. Therefore it is wrong to cast 'p' to struct rv_monitor *. This wrong type cast has been there since the beginning. But it still worked because the list_head was the first field in struct rv_monitor_def. This is no longer true since commit24cbfe18d5("rv: Merge struct rv_monitor_def into struct rv_monitor") moved the list_head, and this wrong type cast became a functional problem. Properly use container_of() instead. Fixes:24cbfe18d5("rv: Merge struct rv_monitor_def into struct rv_monitor") Signed-off-by: Nam Cao <[email protected]> Reviewed-by: Gabriele Monaco <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Gabriele Monaco <[email protected]>
This commit is contained in:
1 parent
03ee64b5e5
commit
de090d1cca
1 file changed
+1
-1
@@ -495,7 +495,7 @@ static void *available_monitors_next(struct seq_file *m, void *p, loff_t *pos)
|
||||
*/
|
||||
static void *enabled_monitors_next(struct seq_file *m, void *p, loff_t *pos)
|
||||
{
|
||||
struct rv_monitor *mon = p;
|
||||
struct rv_monitor *mon = container_of(p, struct rv_monitor, list);
|
||||
|
||||
(*pos)++;
|
||||
|
||||
|
||||
Reference in new issue
Block a user