imrcpan/erofs-linux
1
0 Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git synced 2026-11-09 19:10:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

signal: oom_kill_task: use SEND_SIG_FORCED instead of force_sig()

Browse Source 
Change oom_kill_task() to use do_send_sig_info(SEND_SIG_FORCED) instead
of force_sig(SIGKILL).  With the recent changes we do not need force_ to
kill the CLONE_NEWPID tasks.

And this is more correct.  force_sig() can race with the exiting thread
even if oom_kill_task() checks p->mm != NULL, while
do_send_sig_info(group => true) kille the whole process.

Signed-off-by: Oleg Nesterov <[email protected]>
Cc: Tejun Heo <[email protected]>
Cc: Anton Vorontsov <[email protected]>
Cc: "Eric W. Biederman" <[email protected]>
Cc: KOSAKI Motohiro <[email protected]>
Cc: David Rientjes <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
This commit is contained in:
Oleg Nesterov authored and Linus Torvalds committed 2012-03-23 16:58:41 -07:00
1 parent def8cf7256
commit d2d393099d
1 file changed
+2 -2
Download Patch File Download Diff File Expand all files Collapse all files
mm/oom_kill.c
+2 -2
View File
@@ -521,11 +521,11 @@ static void oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order,
pr_err("Kill process %d (%s) sharing same memory\n",
task_pid_nr(p), p->comm);
task_unlock(p);
force_sig(SIGKILL, p);
do_send_sig_info(SIGKILL, SEND_SIG_FORCED, p, true);
}
set_tsk_thread_flag(victim, TIF_MEMDIE);
force_sig(SIGKILL, victim);
do_send_sig_info(SIGKILL, SEND_SIG_FORCED, victim, true);
}
#undef K