imrcpan/erofs-linux
1
0 Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git synced 2026-11-07 10:01:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

evm: Fix memleak in init_desc

Browse Source 
tmp_tfm is allocated, but not freed on subsequent kmalloc failure, which
leads to a memory leak.  Free tmp_tfm.

Fixes: d46eb36995 ("evm: crypto hash replaced by shash")
Signed-off-by: Dinghao Liu <[email protected]>
[[email protected]: formatted/reworded patch description]
Signed-off-by: Mimi Zohar <[email protected]>
This commit is contained in:
Dinghao Liu authored and Mimi Zohar committed 2021-01-13 07:22:12 -05:00
1 parent 7c53f6b671
commit ccf11dbaa0
1 file changed
+5 -2
Download Patch File Download Diff File Expand all files Collapse all files
security/integrity/evm/evm_crypto.c
+5 -2
View File
@@ -73,7 +73,7 @@ static struct shash_desc *init_desc(char type, uint8_t hash_algo)
{
long rc;
const char *algo;
struct crypto_shash **tfm, *tmp_tfm;
struct crypto_shash **tfm, *tmp_tfm = NULL;
struct shash_desc *desc;
if (type == EVM_XATTR_HMAC) {
@@ -118,13 +118,16 @@ unlock:
alloc:
desc = kmalloc(sizeof(*desc) + crypto_shash_descsize(*tfm),
GFP_KERNEL);
if (!desc)
if (!desc) {
crypto_free_shash(tmp_tfm);
return ERR_PTR(-ENOMEM);
}
desc->tfm = *tfm;
rc = crypto_shash_init(desc);
if (rc) {
crypto_free_shash(tmp_tfm);
kfree(desc);
return ERR_PTR(rc);
}