imrcpan/erofs-linux
1
0 Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git synced 2026-11-07 10:01:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

[SCSI] sd: Reduce buffer size for vpd request

Browse Source 
Somehow older areca firmware versions have issues with
scsi_get_vpd_page() and a large buffer, the firmware
seems to crash and the scsi error-handler will start endless
recovery retries.
Limiting the buf-size to 64-bytes fixes this issue with older
firmware versions (<1.49 for my controller).

Fixes a regression with areca controllers and older firmware versions
introduced by commit: 66c28f9712

Reported-by: Nix <[email protected]>
Tested-by: Nix <[email protected]>
Signed-off-by: Bernd Schubert <[email protected]>
Cc: [email protected] # delay inclusion for 2 months for testing
Acked-by: Martin K. Petersen <[email protected]>
Signed-off-by: James Bottomley <[email protected]>
This commit is contained in:
Bernd Schubert authored and James Bottomley committed 2013-10-25 09:58:12 +01:00
1 parent 51d648af58
commit af73623f5f
1 file changed
+4 -1
Download Patch File Download Diff File Expand all files Collapse all files
drivers/scsi/sd.c
+4 -1
View File
@@ -2639,13 +2639,16 @@ static void sd_read_write_same(struct scsi_disk *sdkp, unsigned char *buffer)
struct scsi_device *sdev = sdkp->device;
if (scsi_report_opcode(sdev, buffer, SD_BUF_SIZE, INQUIRY) < 0) {
/* too large values might cause issues with arcmsr */
int vpd_buf_len = 64;
sdev->no_report_opcodes = 1;
/* Disable WRITE SAME if REPORT SUPPORTED OPERATION
* CODES is unsupported and the device has an ATA
* Information VPD page (SAT).
*/
if (!scsi_get_vpd_page(sdev, 0x89, buffer, SD_BUF_SIZE))
if (!scsi_get_vpd_page(sdev, 0x89, buffer, vpd_buf_len))
sdev->no_write_same = 1;
}