mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git
synced 2026-10-31 06:14:39 +01:00
drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION
The commitc242f48433("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' to an effective 'select FB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y. This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE as reported by Arthur Grillo, e.g: WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] Selected by [y]: - DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n] Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console. Fixes:c242f48433("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") Reported-by: Arthur Grillo <[email protected]> Closes: https://lore.kernel.org/dri-devel/[email protected] Suggested-by: Arnd Bergmann <[email protected]> Signed-off-by: Javier Martinez Canillas <[email protected]> Acked-by: Daniel Vetter <[email protected]> Reviewed-by: Arthur Grillo <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
This commit is contained in:
1 file changed
-1
@@ -135,7 +135,6 @@ config DRM_DEBUG_MODESET_LOCK
|
||||
config DRM_FBDEV_EMULATION
|
||||
bool "Enable legacy fbdev support for your modesetting driver"
|
||||
depends on DRM
|
||||
select FRAMEBUFFER_CONSOLE if !EXPERT
|
||||
select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE
|
||||
default y
|
||||
help
|
||||
|
||||
Reference in new issue
Block a user