imrcpan/erofs-linux
1
0 Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git synced 2026-11-06 09:33:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

bonding: Fix reference count leak in bond_sysfs_slave_add.

Browse Source 
kobject_init_and_add() takes reference even when it fails.
If this function returns an error, kobject_put() must be called to
properly clean up the memory associated with the object. Previous
commit "b8eb718348b8" fixed a similar problem.

Fixes: 07699f9a7c ("bonding: add sysfs /slave dir for bond slave devices.")
Signed-off-by: Qiushi Wu <[email protected]>
Acked-by: Jay Vosburgh <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
This commit is contained in:
Qiushi Wu authored and David S. Miller committed 2020-05-28 11:08:16 -07:00
1 parent 2200313aa0
commit a068aab422
1 file changed
+3 -1
Download Patch File Download Diff File Expand all files Collapse all files
drivers/net/bonding/bond_sysfs_slave.c
+3 -1
View File
@@ -149,8 +149,10 @@ int bond_sysfs_slave_add(struct slave *slave)
err = kobject_init_and_add(&slave->kobj, &slave_ktype,
&(slave->dev->dev.kobj), "bonding_slave");
if (err)
if (err) {
kobject_put(&slave->kobj);
return err;
}
for (a = slave_attrs; *a; ++a) {
err = sysfs_create_file(&slave->kobj, &((*a)->attr));