imrcpan/erofs-linux
1
0 Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git synced 2026-10-30 22:03:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

ipmi:ssif: Clean up kthread on errors

Browse Source 
If an error occurs after the ssif kthread is created, but before the
main IPMI code starts the ssif interface, the ssif kthread will not
be stopped.

So make sure the kthread is stopped on an error condition if it is
running.

Fixes: 259307074b ("ipmi: Add SMBus interface driver (SSIF)")
Reported-by: Li Xiao <<[email protected]>
Cc: [email protected]
Reviewed-by: Li Xiao <[email protected]>
Signed-off-by: Corey Minyard <[email protected]>
This commit is contained in:
Corey Minyard committed 2026-04-17 06:47:40 -05:00
1 parent 91eb7ec726
commit 75c486cb1b
1 file changed
+12 -1
Download Patch File Download Diff File Expand all files Collapse all files
drivers/char/ipmi/ipmi_ssif.c
+12 -1
View File
@@ -1268,8 +1268,10 @@ static void shutdown_ssif(void *send_info)
ssif_info->stopping = true;
timer_delete_sync(&ssif_info->watch_timer);
timer_delete_sync(&ssif_info->retry_timer);
if (ssif_info->thread)
if (ssif_info->thread) {
kthread_stop(ssif_info->thread);
ssif_info->thread = NULL;
}
}
static void ssif_remove(struct i2c_client *client)
@@ -1912,6 +1914,15 @@ static int ssif_probe(struct i2c_client *client)
out:
if (rv) {
/*
* If ipmi_register_smi() starts the interface, it will
* call shutdown and that will free the thread and set
* it to NULL. Otherwise it must be freed here.
*/
if (ssif_info->thread) {
kthread_stop(ssif_info->thread);
ssif_info->thread = NULL;
}
if (addr_info)
addr_info->client = NULL;