imrcpan/erofs-linux
1
0 Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git synced 2026-11-09 11:00:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

mtd: fix memory leaks in phram_setup

Browse Source 
There are two code paths in drivers/mtd/devices/phram.c::phram_setup() that
will leak memory.
Memory is allocated to the variable 'name' with kmalloc() by the
parse_name() function, but if we leave by way of the parse_err() macro,
then that memory is never kfree()'d, nor is it ever used with
register_device() so it won't be freed later either - leak.

Found by the Coverity checker as #593 - simple fix below.

Signed-off-by: Jesper Juhl <[email protected]>
Signed-off-by: David Woodhouse <[email protected]>
This commit is contained in:
Jesper Juhl authored and David Woodhouse committed 2006-05-14 00:13:30 +01:00
1 parent e0c7d76753
commit 4f678a58d3
1 file changed
+6 -2
Download Patch File Download Diff File Expand all files Collapse all files
drivers/mtd/devices/phram.c
+6 -2
View File
@@ -266,12 +266,16 @@ static int phram_setup(const char *val, struct kernel_param *kp)
return 0;
ret = parse_num32(&start, token[1]);
if (ret)
if (ret) {
kfree(name);
parse_err("illegal start address\n");
}
ret = parse_num32(&len, token[2]);
if (ret)
if (ret) {
kfree(name);
parse_err("illegal device length\n");
}
register_device(name, start, len);