mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git
synced 2026-10-31 06:14:39 +01:00
ipv6: switch inet6_addr_hash() to less predictable hash
In commit3f27fb2321("ipv6: addrconf: add per netns perturbation in inet6_addr_hash()"), I added net_hash_mix() in inet6_addr_hash() to get better hash dispersion, at a time all netns were sharing the hash table. Since then, commit21a216a8fc("ipv6/addrconf: allocate a per netns hash table") made the hash table per netns. We could remove the net_hash_mix() from inet6_addr_hash(), but there is still an issue with ipv6_addr_hash(). It is highly predictable and a malicious user can easily create thousands of IPv6 addresses all stored in the same hash bucket. Switch to __ipv6_addr_jhash(). We could use a dedicated secret, or reuse net_hash_mix() as I did in this patch. Signed-off-by: Eric Dumazet <[email protected]> Reviewed-by: David Ahern <[email protected]> Reviewed-by: Kuniyuki Iwashima <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
This commit is contained in:
1 parent
2518b11963
commit
4a0ec2aa07
1 file changed
+1
-1
+1
-1
@@ -1016,7 +1016,7 @@ ipv6_link_dev_addr(struct inet6_dev *idev, struct inet6_ifaddr *ifp)
|
||||
|
||||
static u32 inet6_addr_hash(const struct net *net, const struct in6_addr *addr)
|
||||
{
|
||||
u32 val = ipv6_addr_hash(addr) ^ net_hash_mix(net);
|
||||
u32 val = __ipv6_addr_jhash(addr, net_hash_mix(net));
|
||||
|
||||
return hash_32(val, IN6_ADDR_HSIZE_SHIFT);
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user