mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git
synced 2026-11-14 14:01:57 +01:00
perf hists browser: Print overhead percent value for first-level callchain
Currently perf report on TUI doesn't print percent for first-level
callchain entry.
I guess it (wrongly) assumes that there's only a single callchain in the
first level.
This patch fixes it by handling the first level callchains same as
others - if it's not 100% it should print the percent value.
Also it'll affect other callchains in the other way around - if it's
100% (single callchain) it should not print the percentage.
Before:
- 30.95% 6.84% abc2 abc2 [.] a
- a
- 70.00% c
- 100.00% apic_timer_interrupt
smp_apic_timer_interrupt
local_apic_timer_interrupt
hrtimer_interrupt
...
+ 30.00% b
+ __libc_start_main
After:
- 30.95% 6.84% abc2 abc2 [.] a
- 77.90% a
- 70.00% c
- apic_timer_interrupt
smp_apic_timer_interrupt
local_apic_timer_interrupt
hrtimer_interrupt
...
+ 30.00% b
+ 22.10% __libc_start_main
Reported-by: Arnaldo Carvalho de Melo <[email protected]>
Signed-off-by: Namhyung Kim <[email protected]>
Cc: Andi Kleen <[email protected]>
Cc: David Ahern <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
This commit is contained in:
1 parent
4e6e311e59
commit
4087d11cd9
1 file changed
+12
-2
@@ -542,8 +542,11 @@ static int hist_browser__show_callchain(struct hist_browser *browser,
|
||||
struct rb_node *node;
|
||||
int first_row = row, offset = level * LEVEL_OFFSET_STEP;
|
||||
u64 new_total;
|
||||
bool need_percent;
|
||||
|
||||
node = rb_first(root);
|
||||
need_percent = !!rb_next(node);
|
||||
|
||||
while (node) {
|
||||
struct callchain_node *child = rb_entry(node, struct callchain_node, rb_node);
|
||||
struct rb_node *next = rb_next(node);
|
||||
@@ -560,7 +563,7 @@ static int hist_browser__show_callchain(struct hist_browser *browser,
|
||||
|
||||
if (first)
|
||||
first = false;
|
||||
else if (level > 1)
|
||||
else if (need_percent)
|
||||
extra_offset = LEVEL_OFFSET_STEP;
|
||||
|
||||
folded_sign = callchain_list__folded(chain);
|
||||
@@ -573,7 +576,7 @@ static int hist_browser__show_callchain(struct hist_browser *browser,
|
||||
str = callchain_list__sym_name(chain, bf, sizeof(bf),
|
||||
browser->show_dso);
|
||||
|
||||
if (was_first && level > 1) {
|
||||
if (was_first && need_percent) {
|
||||
double percent = cumul * 100.0 / total;
|
||||
|
||||
if (asprintf(&alloc_str, "%2.2f%% %s", percent, str) < 0)
|
||||
@@ -790,6 +793,13 @@ static int hist_browser__show_entry(struct hist_browser *browser,
|
||||
.is_current_entry = current_entry,
|
||||
};
|
||||
|
||||
if (callchain_param.mode == CHAIN_GRAPH_REL) {
|
||||
if (symbol_conf.cumulate_callchain)
|
||||
total = entry->stat_acc->period;
|
||||
else
|
||||
total = entry->stat.period;
|
||||
}
|
||||
|
||||
printed += hist_browser__show_callchain(browser,
|
||||
&entry->sorted_chain, 1, row, total,
|
||||
hist_browser__show_callchain_entry, &arg,
|
||||
|
||||
Reference in new issue
Block a user