imrcpan/erofs-linux
1
0 Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git synced 2026-11-01 23:04:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

nfc: Ensure presence of required attributes in the deactivate_target handler

Browse Source 
Check that the NFC_ATTR_TARGET_INDEX attributes (in addition to
NFC_ATTR_DEVICE_INDEX) are provided by the netlink client prior to
accessing them. This prevents potential unhandled NULL pointer dereference
exceptions which can be triggered by malicious user-mode programs,
if they omit one or both of these attributes.

Signed-off-by: Young Xiao <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
This commit is contained in:
Young Xiao authored and David S. Miller committed 2019-06-14 08:48:08 -07:00
1 parent b8003cef2e
commit 385097a367
1 file changed
+2 -1
Download Patch File Download Diff File Expand all files Collapse all files
net/nfc/netlink.c
+2 -1
View File
@@ -911,7 +911,8 @@ static int nfc_genl_deactivate_target(struct sk_buff *skb,
u32 device_idx, target_idx;
int rc;
if (!info->attrs[NFC_ATTR_DEVICE_INDEX])
if (!info->attrs[NFC_ATTR_DEVICE_INDEX] ||
!info->attrs[NFC_ATTR_TARGET_INDEX])
return -EINVAL;
device_idx = nla_get_u32(info->attrs[NFC_ATTR_DEVICE_INDEX]);