mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git
synced 2026-10-29 13:23:23 +01:00
misc: sram: Generate unique names for subpools
The current code will, if we do not specify unique labels
for the SRAM subnodes, fail to register several nodes named
the same.
Example:
sram@40020000 {
(...)
sram@0 {
(...)
};
sram@1000 {
(...)
};
};
Since the child->name in both cases will be "sram" the
gen_pool_create() will fail because the name is not unique.
Use dev_name() for the device as this will have bus ID
set to the fully translated address for the node, and that
will always be unique.
Signed-off-by: Linus Walleij <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
This commit is contained in:
1 parent
38bd22dac7
commit
21e5a2d10c
1 file changed
+5
-4
+5
-4
@@ -235,10 +235,11 @@ static int sram_reserve_regions(struct sram_dev *sram, struct resource *res)
|
||||
goto err_chunks;
|
||||
}
|
||||
if (!label)
|
||||
label = child->name;
|
||||
|
||||
block->label = devm_kstrdup(sram->dev,
|
||||
label, GFP_KERNEL);
|
||||
block->label = devm_kasprintf(sram->dev, GFP_KERNEL,
|
||||
"%s", dev_name(sram->dev));
|
||||
else
|
||||
block->label = devm_kstrdup(sram->dev,
|
||||
label, GFP_KERNEL);
|
||||
if (!block->label) {
|
||||
ret = -ENOMEM;
|
||||
goto err_chunks;
|
||||
|
||||
Reference in new issue
Block a user