serial: sunhv: Initialize lock for non-registered console

The commit a3cb39d258
("serial: core: Allow detach and attach serial device for console")
changed a bit logic behind lock initialization since for most of the console
driver it's supposed to have lock already initialized even if console is not
enabled. However, it's not the case for Sparc HV console.

Initialize lock explicitly in the ->probe().

Note, there is still an open question should or shouldn't not this driver
register console properly.

Fixes: a3cb39d258 ("serial: core: Allow detach and attach serial device for console")
Reported-by: Anatoly Pugachev <[email protected]>
Cc: David Miller <[email protected]>
Signed-off-by: Andy Shevchenko <[email protected]>
Tested-by: Anatoly Pugachev <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit is contained in:
Andy Shevchenko authored and Greg Kroah-Hartman committed 2020-04-16 16:16:52 +02:00
1 parent 18cc7ac8a2
commit 0f87aa66e8
1 file changed
+3
+3
View File
@@ -567,6 +567,9 @@ static int hv_probe(struct platform_device *op)
sunserial_console_match(&sunhv_console, op->dev.of_node,
&sunhv_reg, port->line, false);
/* We need to initialize lock even for non-registered console */
spin_lock_init(&port->lock);
err = uart_add_one_port(&sunhv_reg, port);
if (err)
goto out_unregister_driver;