erofs-freebsd-out-tree/docs/pre12-batch-08.md

Pre-12 Batch 08: xattr helper order

Date: 2026-08-13

Scope

• Moved the complete static erofs_listxattr_foreach function block to immediately precede erofs_getxattr_foreach in src/xattr.c.
• Made no changes to either function body, signature, visibility, callers, or conditional-compilation context.

Static proof

• The exact function block from static int through its closing brace had SHA-256 0541c211f78a19f39caeebdafe73bdd0a7064e996686a7b45c9c651160ed98ae before and after the move.
• The target remains one static definition with two call sites, in the inline and shared xattr iterators.
• erofs_getxattr_foreach remains one definition with the same two call sites; its complete block is unchanged.
• Both helpers remain in the same unconditional compilation region after struct erofs_xattr_iter and before the iterator functions, so no forward declaration or conditional boundary was introduced.
• The source diff is a pure block move; adjacent xattr and ACL logic is unchanged.
• git diff --check and git diff --cached --check were required for this batch.

Deferred validation

No build, QEMU, smoke, feature, or other dynamic validation was run for this batch. Final KLD and Plain/LZ4/LZMA validation remains deferred.